[Intel-wired-lan] [next PATCH S37 07/15] i40e: Clean up MSIX irqs before suspend

Bimmy Pujari bimmy.pujari at intel.com
Mon May 16 17:26:37 UTC 2016

From: Greg Rose <gregory.v.rose at intel.com>

The i40e_suspend() function calls another function that preps the device
for the power save and resume by freeing all the tx/rx resources and
interrupts but that function does not free the "other" causes interrupt
vector and irq. It also fails to call synchronize_irq() before freeing
the irq vectors.  This sometimes may result in some AER errors on those
systems with that PCIe error reporting feature enabled.

Call synchronize_irq() before freeing irq vectors and explicitly free
the other causes interrupt resources and shut down that MSIX interrupt.

Signed-off-by: Greg Rose <gregory.v.rose at intel.com>
Change-ID: Ib88e4536756518a352446da0232189716618ad81
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 3439e9f..d71b6bc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -3955,6 +3955,7 @@ static void i40e_vsi_free_irq(struct i40e_vsi *vsi)
 			/* clear the affinity_mask in the IRQ descriptor */
+			synchronize_irq(pf->msix_entries[vector].vector);
@@ -11535,6 +11536,8 @@ static int i40e_suspend(struct pci_dev *pdev, pm_message_t state)
 	wr32(hw, I40E_PFPM_APM, (pf->wol_en ? I40E_PFPM_APM_APME_MASK : 0));
 	wr32(hw, I40E_PFPM_WUFC, (pf->wol_en ? I40E_PFPM_WUFC_MAG_MASK : 0));
+	i40e_stop_misc_vector(pf);
 	pci_wake_from_d3(pdev, pf->wol_en);
 	pci_set_power_state(pdev, PCI_D3hot);

More information about the Intel-wired-lan mailing list