[Intel-wired-lan] [next PATCH S37 12/15] i40evf: always activate correct MAC address filter

Bimmy Pujari bimmy.pujari at intel.com
Mon May 16 17:26:42 UTC 2016

From: Mitch Williams <mitch.a.williams at intel.com>

Always add MAC address at the tail of the MAC filter list. Since the
device's "real" MAC address is added first, it will always be at the
beginning of the list. This prevents an issue where the "real" MAC
filter might not get added if too many other filters are added before
bringing the interface up.

Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
Change-ID: I34a8aeebeb0cb87a44b24118adc4176c7b943c1c
Testing Hints : Add a lot of MAC filters before bringing the interface
up. Ensure it still works on the base MAC address.

 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index ae67be4..41581ad 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -825,7 +825,7 @@ i40evf_mac_filter *i40evf_add_filter(struct i40evf_adapter *adapter,
 		ether_addr_copy(f->macaddr, macaddr);
-		list_add(&f->list, &adapter->mac_filter_list);
+		list_add_tail(&f->list, &adapter->mac_filter_list);
 		f->add = true;
 		adapter->aq_required |= I40EVF_FLAG_AQ_ADD_MAC_FILTER;

More information about the Intel-wired-lan mailing list