[Intel-wired-lan] [next PATCH S37 06/15] i40evf: don't overflow buffer

Bowers, AndrewX andrewx.bowers at intel.com
Tue May 17 16:41:29 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Monday, May 16, 2016 10:27 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S37 06/15] i40evf: don't overflow
> buffer
> 
> From: Mitch Williams <mitch.a.williams at intel.com>
> 
> If the user adds an obscene amount of MAC addresses, the driver will run
> into the situation where it has too many address requests to fit into a single
> PF message. The driver checks for this case, and calculates the maximum
> number of messages that it can send. Then it completely ignores this count
> and overflows the buffer.
> 
> Fix this by checking the address count and bailing out of the loop at the
> appropriate time.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> Change-ID: If8dcbb04602c75941dc0cd8309065e1de9ca791c
> ---
> Testing Hints : Add a thousand filters as quickly as possible.
> 
>  drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Successfully added 1000 MACs without error or overflow



More information about the Intel-wired-lan mailing list