[Intel-wired-lan] [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

Alex Duyck aduyck at mirantis.com
Mon Jun 13 19:16:28 UTC 2016


On Mon, Jun 13, 2016 at 12:14 PM, Hannes Frederic Sowa
<hannes at redhat.com> wrote:
> On 13.06.2016 20:41, Jesse Gross wrote:
>> On Mon, Jun 13, 2016 at 10:48 AM, Alexander Duyck <aduyck at mirantis.com> wrote:
>>> This change replaces the network device operations for adding or removing a
>>> VXLAN port with operations that are more generically defined to be used for
>>> any UDP offload port but provide a type.  As such by just adding a line to
>>> verify that the offload type if VXLAN we can maintain the same
>>> functionality.
>>>
>>> Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
>>
>> It looks like bnxt actually has a hardcoded offload of the Geneve port
>> rather than using the registration (maybe it predated it?). It would
>> be nice to incorporate that into your unified handler as well.
>>
>> I think you could actually just kill all of these
>> CONFIG_VXLAN/CONFIG_GENEVE checks (across all the drivers, not just
>> this one). They shouldn't be necessary any more now that there's no
>> longer strong linkage to the tunnel drivers.
>
> Yes, agreed. We can remove the CONFIG_VXLAN and CONFIG_GENEVE stuff now.
> But I think this can be a separate series.

Actually it should be pretty easy to do all of this in the same
series.  I am directly effecting the code where it is wrapped up
anyway.  Dropping the defines will make this easier for me to test.

- Alex


More information about the Intel-wired-lan mailing list