[Intel-wired-lan] [PATCH net] ixgbe: napi_poll must return the work done

Alexander Duyck alexander.duyck at gmail.com
Wed Jun 15 15:20:57 UTC 2016


On Wed, Jun 15, 2016 at 6:37 AM, Paolo Abeni <pabeni at redhat.com> wrote:
> Currently the function ixgbe_poll() returns 0 when it clean completely
> the rx rings, but this foul budget accounting in core code.
> Fix this returning the actual work done, capped to weight - 1, since
> the core doesn't allow to return the full budget when the driver modifies
> the napi status
>
> Signed-off-by: Paolo Abeni <pabeni at redhat.com>

I think the origin of reporting 0 was actually compatibility with some
NAPI code floating around from before the 2.6.24 kernel.

I'd be curious to know how much this is actually fouling things up.
Can you point to any specific issues it was causing?  If you end up
having to submit a v2 for any reason it might be useful if you can
provide the additional details on what actual issue it was causing.

You might also want to look at the other Intel drivers, specifically
ixgbevf and fm10k as I believe we have similar code in those drivers
as well.

Acked-by: Alexander Duyck <aduyck at mirantis.com>


More information about the Intel-wired-lan mailing list