[Intel-wired-lan] [net-next PATCH v2 02/17] net: Combine GENEVE and VXLAN port notifiers into single functions

Jesse Gross jesse at kernel.org
Wed Jun 15 23:50:46 UTC 2016


On Wed, Jun 15, 2016 at 3:07 PM, Alexander Duyck <aduyck at mirantis.com> wrote:
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index e5e33cd01082..d12ee3a92fb5 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
>  static void geneve_notify_del_rx_port(struct geneve_sock *gs)
>  {
> -       struct net_device *dev;
> -       struct sock *sk = gs->sock->sk;
> -       struct net *net = sock_net(sk);
> -       sa_family_t sa_family = geneve_get_sk_family(gs);
> -       __be16 port = inet_sk(sk)->inet_sport;
> -
> -       rcu_read_lock();
> -       for_each_netdev_rcu(net, dev) {
> -               if (dev->netdev_ops->ndo_del_geneve_port)
> -                       dev->netdev_ops->ndo_del_geneve_port(dev, sa_family,
> -                                                            port);
> -       }
> -
> -       rcu_read_unlock();
> +       udp_tunnel_notify_add_rx_port(gs->sock, UDP_TUNNEL_TYPE_GENEVE);
>  }

Looks like a typo here - calling add instead of delete.


More information about the Intel-wired-lan mailing list