[Intel-wired-lan] [PATCH] (resend) ixgbe: always initialize setup_fc

[zhuyj]

Sure. setup_fc should not be null. Emil, your patch can fix it well.

On Fri, Jul 8, 2016 at 8:18 AM, Tantilov, Emil S <emil.s.tantilov at intel.com>
wrote:

> >-----Original Message-----
> >From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org]
> On
> >Behalf Of Rustad, Mark D
> >Sent: Wednesday, July 06, 2016 4:01 PM
> >To: Patrick McLean <patrickm at gaikai.com>
> >Cc: netdev <netdev at vger.kernel.org>; intel-wired-lan <intel-wired-
> >lan at lists.osuosl.org>
> >Subject: Re: [Intel-wired-lan] [PATCH] (resend) ixgbe: always initialize
> >setup_fc
> >
> >Patrick McLean <patrickm at gaikai.com> wrote:
> >
> >> Gmail mangled my first message, sorry about that. Second attempt.
> >>
> >> In ixgbe_init_mac_link_ops_X550em, the code has a special case for
> >> backplane media type, but does not fall through to the default case,
> >> so the setup_fc never gets initialized. This causes a panic when it
> >> later tries to set up the card, and the kernel dereferences the null
> >> pointer.
> >>
> >> This patch lets the the function fall through, which initialized
> >> setup_fc properly.
> >
> >I don't think that this is the right fix. My memory is that fc autoneg is
>
> setup_fc() does not configure FC autoneg and it should always be set.
>
> I posted an alternative patch that simply sets setup_fc at the beginning of
> the function. The fall-through in the switch statement is not a good
> solution
> because it won't work in case we need to add another case.
>
> http://patchwork.ozlabs.org/patch/646228/
>
> Thanks,
> Emil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160708/c06a79a6/attachment.html>