[Intel-wired-lan] [PATCH v2 01/18] fm10k: prevent multiple threads updating statistics
Singh, Krishneil K
krishneil.k.singh at intel.com
Mon Jul 11 19:24:49 UTC 2016
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Tuesday, June 7, 2016 4:09 PM
To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
Subject: [Intel-wired-lan] [PATCH v2 01/18] fm10k: prevent multiple threads updating statistics
Also prevent updating stats while the interface is down. If we're already updating stats, just return doing nothing. When we take the device down, block stat updates until we come back up. This ensures that we avoid tearing down rings when we're updating statistics, and prevents updating statistics until we're up.
We can't re-use the __FM10K_DOWN for this because it wouldn't prevent multiple threads from accessing statistics. Neither does it prevent the case where we start updating stats and then start going down in another thread.
The fm10k_get_stats64 is except from this, because it has a completely different flow which does not suffer from the same issues as fm10k_update_stats might.
Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
---
Tested-by: Krishneil Singh <Krishneil.k.singh at intel.com>
More information about the Intel-wired-lan
mailing list