[Intel-wired-lan] [next PATCH S40 06/13] i40e: Fix static analysis tool warning

Bimmy Pujari bimmy.pujari at intel.com
Mon Jul 25 23:15:48 UTC 2016


From: Dave Ertman <david.m.ertman at intel.com>

This patch fixes a problem where a static analysis tool generates a warning 
for "INVARIANT_CONDITION: Expression 'enabled_tc' used in the condition 
always yields the same result."

Without this patch, the driver will not pass the static analysis tool checks 
without generating warnings.

This patch fixes the problem by eliminating the irrelevant check and redundant 
assignment for the value of enabled_tc.

Signed-off-by: Dave Ertman <david.m.ertman at intel.com>
Change-ID: Ia7d44cb050f507df7de333e96369d322e08bf408
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index b6f9b11..c130149 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4608,8 +4608,6 @@ static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)
 	else
 		return 1; /* Only TC0 */
 
-	/* At least have TC0 */
-	enabled_tc = (enabled_tc ? enabled_tc : 0x1);
 	for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
 		if (enabled_tc & BIT(i))
 			num_tc++;
-- 
2.4.11



More information about the Intel-wired-lan mailing list