[Intel-wired-lan] [next PATCH S40-V2 06/12] i40e: don't allow reduction of channels below active FD rules

Bowers, AndrewX andrewx.bowers at intel.com
Wed Aug 3 17:24:32 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Wednesday, July 27, 2016 12:03 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S40-V2 06/12] i40e: don't allow
> reduction of channels below active FD rules
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> If a driver is unable to maintain all current user supplied settings from ethtool
> (or other sources), it is not ok for a user request to succeed and silently
> trample over previous configuration.
> 
> To that end, if you change the number of channels, it must not be allowed to
> reduce the number of channels (queues) below the current flow director
> filter rules targets. In this case, return -EINVAL when a request to reduce the
> number of channels would do so. In addition log a warning to the kernel
> buffer explaining why we failed, and report the rules which prevent us from
> lowering the number of channels.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Change-ID: If41464d63d7aab11cedf09e4f3aa1a69e21ffd88
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 24
> ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Unable to set channels lower than channel used for flow director rules



More information about the Intel-wired-lan mailing list