[Intel-wired-lan] [next PATCH 1/5] i40e: Introduce devlink interface.

Alexander Duyck alexander.duyck at gmail.com
Wed Aug 10 16:01:33 UTC 2016


On Thu, Aug 4, 2016 at 9:49 AM, Sridhar Samudrala
<sridhar.samudrala at intel.com> wrote:
> Add initial devlink support to set/get the mode of SRIOV switch.
> This patch allows the mode to be set to either 'legacy' or 'switchdev', but
> doesn't implement any functionality to create vf representors in switchdev
> mode.
>
> With smode support in iproute2 'devlink' utility, switch mode can be set
> and get via following commands.
>
>     # devlink dev smode pci/0000:05:00.0
>     mode: legacy
>     # devlink dev set pci/0000:05:00.0 smode switchdev
>     # devlink dev smode pci/0000:05:00.0
>     mode: switchdev
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala at intel.com>

I really don't see much value in this patch.  If you are going to
support SwitchDev then just do it.  Otherwise you are adding extra
overhead for maintaining two different modes.

I would recommend putting this series out to netdev as an RFC.
Submitting it to intel-wired-lan is kind of pointless as the audience
it to small to get any valuable review.

- Alex


More information about the Intel-wired-lan mailing list