[Intel-wired-lan] [next PATCH S43 1/3] i40e: Correcting mutex usage in client code

Bimmy Pujari bimmy.pujari at intel.com
Wed Aug 17 23:04:06 UTC 2016


From: Avinash Dayanand <avinash.dayanand at intel.com>

Correcting the mutex usage, in client_subtask(), mutex_unlock has
to be called just before client_del_instance() since this function opens
and later closes the same mutex again.
Similarly in client_is_registered removing the mutex since it closes
the mutex twice.

This is a patch suggested by RDMA team.

Signed-off-by: Avinash Dayanand <avinash.dayanand at intel.com>
Change-ID: Icce519c266e4221b8a2a72a15ba5bf01750e5852
---
 drivers/net/ethernet/intel/i40e/i40e_client.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index 09a37cf..5404b32 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -576,6 +576,7 @@ void i40e_client_subtask(struct i40e_pf *pf)
 			set_bit(__I40E_CLIENT_INSTANCE_OPENED, &cdev->state);
 		} else {
 			/* remove client instance */
+			mutex_unlock(&i40e_client_instance_mutex);
 			i40e_client_del_instance(pf, client);
 			atomic_dec(&client->ref_cnt);
 			continue;
-- 
2.4.11



More information about the Intel-wired-lan mailing list