[Intel-wired-lan] [PATCH v2] checkpatch.pl: seed camelcase from the provided kernel tree root

Jeff Kirsher jeffrey.t.kirsher at intel.com
Thu Sep 1 02:33:10 UTC 2016


On Thu, 2016-09-01 at 01:04 +0000, Brown, Aaron F wrote:
> > From: Keller, Jacob E
> > Sent: Wednesday, August 31, 2016 3:37 PM
> > To: Brown, Aaron F <aaron.f.brown at intel.com>; Intel Wired LAN <intel-
> > wired-lan at lists.osuosl.org>
> > Subject: RE: [Intel-wired-lan] [PATCH v2] checkpatch.pl: seed camelcase
> from
> > the provided kernel tree root
>> <snip>
> > > total: 0 errors, 2 warnings, 22 lines checked
> > > ---------------------------------------------------------------------
> > > The first is clearly a false warning, thinks checkpatch is the tool
> that found
> > > the error rather than the tool being fixed.  ;)   The second is just
> a long line
> > in
> > > the perl code, which I don't really consider a blocking issue so...
> > >
>> > Ya I saw those. I saw many lines over 80 characters in the file so I
> just
> > assumed we don't bother checking the tool with itself.
> 
> Well, it showed up in as a patch so I ran it through...  But yeah, it
> does not make sense to enforce rules intended for the kernel against
> something else.  Especially as the precedent for line length is clearly
> already in the file

Although it technically is a part of the kernel source since it is in
scripts.  So the question is, should kernel scripts follow the coding
standards?  If so, then yes it should follow its own rules for kernel
source.

Personally I do not think it should be an issue for the contents of
/scripts in the kernel source, but that would be an interesting question to
pose to Joe Perches and the other checkpatch.pl warlords.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160831/8450b5d3/attachment.asc>


More information about the Intel-wired-lan mailing list