[Intel-wired-lan] [PATCH net-next 2/3] i40e: fix MSI-X vector redistribution if hw limit is reached
Bowers, AndrewX
andrewx.bowers at intel.com
Mon Sep 26 18:58:23 UTC 2016
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Stefan Assmann
> Sent: Monday, September 19, 2016 4:38 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; davem at davemloft.net; sassmann at kpanic.de
> Subject: [Intel-wired-lan] [PATCH net-next 2/3] i40e: fix MSI-X vector
> redistribution if hw limit is reached
>
> The driver allocates 1 vector per CPU thread and the current hardware limit
> for vectors is 129 per PF. On systems with 128 or more threads this currently
> means all vectors are used by the PF leaving no room for additional features
> like VMDq, iWARP, etc...
> The code that should redistribute the vectors in this case is broken and never
> triggers. Fixed the code so that it actually triggers if the hardware limit is
> reached and adjust the number of queue pairs accordingly.
> Also the number of initially requested iWARP vectors was not properly saved
> when the vector limit was reached, and therefore always zero.
>
> Comparison with debug statement.
> Before:
> i40e 0000:2d:00.0: VMDq disabled, not enough MSI-X vectors i40e
> 0000:2d:00.0: IWARP disabled, not enough MSI-X vectors i40e 00.0 MSI-X
> vector distribution: PF 128, VMDq 0, FDSB 0, iWARP 0
> After:
> i40e 0000:2d:00.0: MSI-X vector limit reached, attempting to redistribute
> vectors i40e 00.0 MSI-X vector distribution: PF 78, VMDq 8, FDSB 0, iWARP 42
>
> Signed-off-by: Stefan Assmann <sassmann at kpanic.de>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 38 +++++++++++++++++-----
> -------
> 1 file changed, 22 insertions(+), 16 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan
mailing list