[Intel-wired-lan] [PATCH] i40e: Fix bit logic error in failure case

Bowers, AndrewX andrewx.bowers at intel.com
Mon Oct 3 18:53:01 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Dave Ertman
> Sent: Friday, September 30, 2016 1:36 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] i40e: Fix bit logic error in failure case
> 
> Patch a036244c0686 "i40e: Fix kernel panic on enable/disable LLDP"
> introduced an error in bit logic.
> 
> Originally this bit manipulation was meant to clear two bits to indicate that
> DCB was not enabled or capable. An "&" was incorrectly used instead of an
> "|" bit operator to combine the two bitmasks into one.  This also created a
> static checker error since the resultant code was a no-op.
> 
> This patch fixes the error by using the correct bit-wise operator.
> 
> Signed-off-by: Dave Ertman <david.m.ertman at intel.com>
> Found-by: Dan Carpenter <dan.carpenter at oracle.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>



More information about the Intel-wired-lan mailing list