[Intel-wired-lan] [next PATCH S49-V2 08/15] i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters

Bowers, AndrewX andrewx.bowers at intel.com
Fri Oct 7 19:32:04 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Wednesday, October 05, 2016 9:31 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S49-V2 08/15] i40e: properly cleanup
> on allocation failure in i40e_sync_vsi_filters
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Currently, we fail to correctly restore filters on the temporary add list when
> we fail to allocate memory either for deletion or addition.
> Replace calls to "goto out;" with calls to a new location that correctly handles
> memory allocation failures.
> 
> Note that it is safe for us to call i40e_undo_filter_entries on the tmp_del_list
> even after we've deleted filters because at this point it will be empty, so we
> don't need to separate the logic for add and delete failure.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Change-Id: Iee107fd219c6e03e2fd9645c2debf8e8384a8521
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 39 ++++++++++++++++-------
> ------
>  1 file changed, 22 insertions(+), 17 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list