[Intel-wired-lan] [next PATCH S50 2/6] i40e: Reorder logic for coalescing RS bits
andrewx.bowers at intel.com
Fri Oct 14 22:48:07 UTC 2016
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, October 11, 2016 3:27 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S50 2/6] i40e: Reorder logic for
> coalescing RS bits
> From: Alexander Duyck <alexander.h.duyck at intel.com>
> This patch reorders the logic at the end of i40e_tx_map to address the fact
> that the logic was rather convoluted and much larger than it needed to be.
> In order to try and coalesce the code paths I have updated some of the
> comments and repurposed some of the variables in order to reduce
> unnecessary overhead.
> This patch does the following:
> 1. Quit tracking skb->xmit_more with a flag, just max out packet_stride 2.
> Drop tail_bump and do_rs and instead just use desc_count and td_cmd 3.
> Pull comments from ixgbe that make need for wmb() more explicit.
> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> Change-ID: Ic7da85ec75043c634e87fef958109789bcc6317c
> Testing Hints:
> The big area to test for this is performance. This should perform
> as well as the original code if not better. If any signficant
> performance regressions are seen or hangs are seen then this patch
> has failed.
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 105 +++++++++++++----------
> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 -
> drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 105 +++++++++++++---------
> drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 1 -
> 4 files changed, 108 insertions(+), 104 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan