[Intel-wired-lan] [next PATCH S52-V2 10/15] i40e: simplify txd use count calculation

Bowers, AndrewX andrewx.bowers at intel.com
Thu Nov 17 18:06:47 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, November 08, 2016 1:05 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S52-V2 10/15] i40e: simplify txd use
> count calculation
> 
> From: Mitch Williams <mitch.a.williams at intel.com>
> 
> The i40e_txd_use_count function was fast but confusing. In the comments,
> it even admits that it's ugly. So replace it with a new function that is
> (very) slightly faster and has extensive commenting to help the thicker
> among us (including the author, who will forget in a week) understand how it
> works.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> Change-ID: Ifb533f13786a0bf39cb29f77969a5be2c83d9a87
> ---
> Testing Hints : Lots and lots of TSO with various data sizes. This should
> operate exactly as before, with no noticeable performance change.
> 
>  drivers/net/ethernet/intel/i40e/i40e_txrx.h   | 45 +++++++++++++++++-----
> -----
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 45 +++++++++++++++++----
> ------
>  2 files changed, 56 insertions(+), 34 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
No performance degradation with various packet sizes


More information about the Intel-wired-lan mailing list