[Intel-wired-lan] [next PATCH S52-V2 13/15] i40e: remove code to handle dev_addr specially

Bowers, AndrewX andrewx.bowers at intel.com
Thu Nov 17 18:33:14 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, November 08, 2016 1:05 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S52-V2 13/15] i40e: remove code to
> handle dev_addr specially
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> The netdev->dev_addr MAC filter already exists in the MAC/VLAN hash
> table, as it is added when we configure the netdev in
> i40e_configure_netdev. Because we already know that this address will be
> updated in the hash_for_each loops, we do not need to handle it specially.
> This removes duplicate code and simplifies the i40e_vsi_add_vlan and
> i40e_vsi_kill_vlan functions.
> Because we know these filters must be part of the MAC/VLAN hash table,
> this should not have any functional impact on what filters are included and is
> merely a code simplification.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Change-ID: I5e648302dbdd7cc29efc6d203b7019c11f0b5705
> ---
> Testing-hints:
>   Ensure that adding and removing VLANs correctly updates the filters
>   for the MAC address of the device.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 43 +++++------------------------
>  1 file changed, 7 insertions(+), 36 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Adding/removing VLANs correctly updates MAC filter table




More information about the Intel-wired-lan mailing list