[Intel-wired-lan] [next PATCH S53-V2 5/5] i40e: lock service task correctly

Bowers, AndrewX andrewx.bowers at intel.com
Fri Nov 18 17:51:43 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Monday, November 14, 2016 1:07 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S53-V2 5/5] i40e: lock service task
> correctly
> 
> From: Mitch Williams <mitch.a.williams at intel.com>
> 
> The service task lock was being set in the scheduling function, not the actual
> service task. This would potentially leave the bit set for a long time before
> the task actually ran. Furthermore, if the service task takes too long, it calls
> the schedule function to reschedule itself - which would fail to take the lock
> and do nothing.
> 
> Instead, set and clear the lock bit in the service task itself. In the process, get
> rid of the i40e_service_event_complete() function, which is really just two
> lines of code that can be put right in the service task itself.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> Change-ID: I83155e682b686121e2897f4429eb7d3f7c669168
> ---
> Testing Hints : Should be no functional change, particularly around link
> up/down events. This is prep work for using this lock bit in the client.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 24 +++++++-----------------
>  1 file changed, 7 insertions(+), 17 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list