[Intel-wired-lan] [next PATCH S54 08/15] i40e: don't allow i40e_vsi_(add|kill)_vlan to operate when VID<1

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Friday, November 11, 2016 12:40 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S54 08/15] i40e: don't allow
> i40e_vsi_(add|kill)_vlan to operate when VID<1
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Now that we have the separate i40e_(add|rm)_vlan_all_mac functions, we
> should not be using the i40e_vsi_kill_vlan or i40e_vsi_add_vlan functions
> when PVID is set or when VID is less than 1. This allows us to remove some
> checks in i40e_vsi_add_vlan and ensures that callers which need to handle
> VID=0 or VID=-1 don't accidentally invoke the VLAN mode handling used to
> convert filters when entering VLAN mode. We also update the functions to
> take u16 instead of s16 as well since they no longer expect to be called with
> VID=I40E_VLAN_ANY.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Change-ID: Ibddf44a8bb840dde8ceef2a4fdb92fd953b05a57
> ---
> Testing-hints:
>   Ensure that add/remove VLAN works correctly for PFs, and for VFs when
>   not assigning a PVID.
> 
>  drivers/net/ethernet/intel/i40e/i40e.h      |  4 ++--
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 14 ++++++++++----
>  2 files changed, 12 insertions(+), 6 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>