[Intel-wired-lan] [PATCH] i40e: don't truncate match_method assignment

David Miller davem at davemloft.net
Sat Dec 10 04:07:40 UTC 2016


From: Jacob Keller <jacob.e.keller at intel.com>
Date: Fri,  9 Dec 2016 13:39:21 -0800

> The .match_method field is a u8, so we shouldn't be casting to a u16,
> and because it is only one byte, we do not need to byte swap anything.
> Just assign the value directly. This avoids issues on Big Endian
> architectures which would have byte swapped and then incorrectly
> truncated the value.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Cc: Stephen Rothwell <sfr at canb.auug.org.au>
> Cc: Bimmy Pujari <bimmy.pujari at intel.com>
> ---
> Not sure if this was already in Jeff's queue, but since it's an obvious
> fix for the issue found by Stephen, I thought I'd send it out now just
> to make sure. Thanks for catching this, and sorry we didn't find the fix
> earlier.

Jeff, what do you want me to do with this?


More information about the Intel-wired-lan mailing list