[Intel-wired-lan] [next PATCH S57 03/11] i40e: remove unnecessary call to i40e_update_link_info

Bimmy Pujari bimmy.pujari at intel.com
Mon Dec 12 23:44:09 UTC 2016


From: Jacob Keller <jacob.e.keller at intel.com>

This call is made just prior to running i40e_link_event. In
i40e_link_event, we set hw->phy.get_link_info to true just prior to
calling i40e_get_link_status, which conveniently runs
i40e_update_link_info for us. Thus, we are running i40e_update_link_info
twice, which seems like something we don't need to do...

Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
Change-ID: I36467a570f44b7546d218c99e134ff97c2709315
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 51a962c..128a21e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -10777,7 +10777,6 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit)
 		i40e_pf_config_rss(pf);
 
 	/* fill in link information and enable LSE reporting */
-	i40e_update_link_info(&pf->hw);
 	i40e_link_event(pf);
 
 	/* Initialize user-specific link properties */
-- 
2.4.11



More information about the Intel-wired-lan mailing list