[Intel-wired-lan] [next-queue PATCH v3] i40e/i40evf: Update driver to support napi_complete_done changes

Alexander Duyck alexander.duyck at gmail.com
Thu Jan 5 22:05:54 UTC 2017


On Thu, Jan 5, 2017 at 2:05 PM, Alexander Duyck
<alexander.duyck at gmail.com> wrote:
> On Wed, Dec 7, 2016 at 4:14 PM, Alexander Duyck
> <alexander.duyck at gmail.com> wrote:
>> From: Alexander Duyck <alexander.h.duyck at intel.com>
>>
>> Recently napi_complete_done was updated so that it will return zero if we
>> are using the queue vector for busy polling.  When this is the case we
>> don't need to re-enable interrupts as the busy polling will reschedule the
>> NAPI instance when it is finally done polling.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
>> ---
>>
>> v2: Updated code to place the IRQ enabling inside the if statment
>>     This made it so that we are consistent with the recent return value changes
>>
>> v3: Added i40evf changes as well
>>
>>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   |   32 +++++++++++++------------
>>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c |   28 ++++++++++++----------
>>  2 files changed, 32 insertions(+), 28 deletions(-)
>>
>
> Jeff,
>
> This patch causes a performance regression due to the way it interacts
> with the i40e WB on ITR behavior.  Can you please drop it from the
> dev-queue.
>
> Thanks.
>
> - Alex

Re-sending this time and making sure it is sent to Jeff.

Thanks.

- Alex


More information about the Intel-wired-lan mailing list