[Intel-wired-lan] [next-queue PATCH v3] i40e/i40evf: Update driver to support napi_complete_done changes

Jeff Kirsher jeffrey.t.kirsher at intel.com
Thu Jan 5 22:26:19 UTC 2017


On Thu, 2017-01-05 at 14:05 -0800, Alexander Duyck wrote:
> On Wed, Dec 7, 2016 at 4:14 PM, Alexander Duyck
> <alexander.duyck at gmail.com> wrote:
> > From: Alexander Duyck <alexander.h.duyck at intel.com>
> > 
> > Recently napi_complete_done was updated so that it will return zero if
> > we
> > are using the queue vector for busy polling.  When this is the case we
> > don't need to re-enable interrupts as the busy polling will reschedule
> > the
> > NAPI instance when it is finally done polling.
> > 
> > Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> > ---
> > 
> > v2: Updated code to place the IRQ enabling inside the if statment
> >      This made it so that we are consistent with the recent return
> > value changes
> > 
> > v3: Added i40evf changes as well
> > 
> >   drivers/net/ethernet/intel/i40e/i40e_txrx.c   |   32 +++++++++++++---
> > ---------
> >   drivers/net/ethernet/intel/i40evf/i40e_txrx.c |   28 ++++++++++++--
> > --------
> >   2 files changed, 32 insertions(+), 28 deletions(-)
> > 
> 
> Jeff,
> 
> This patch causes a performance regression due to the way it interacts
> with the i40e WB on ITR behavior.  Can you please drop it from the
> dev-queue.

I have dropped the patch from my queue/tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170105/d9e4cb64/attachment.asc>


More information about the Intel-wired-lan mailing list