[Intel-wired-lan] [PATCH net-next] net: Remove usage of net_device last_rx member

David Miller davem at davemloft.net
Wed Jan 18 22:27:50 UTC 2017


From: Tobias Klauser <tklauser at distanz.ch>
Date: Wed, 18 Jan 2017 17:45:01 +0100

> The network stack no longer uses the last_rx member of struct net_device
> since the bonding driver switched to use its own private last_rx in
> commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").
> 
> However, some drivers still (ab)use the field for their own purposes and
> some driver just update it without actually using it.
> 
> Previously, there was an accompanying comment for the last_rx member
> added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
> which asked drivers not to update is, unless really needed. However,
> this commend was removed in commit f8ff080dacec ("bonding: remove
> useless updating of slave->dev->last_rx"), so some drivers added later
> on still did update last_rx.
> 
> Remove all usage of last_rx and switch three drivers (sky2, atp and
> smc91c92_cs) which actually read and write it to use their own private
> copy in netdev_priv.
> 
> Compile-tested with allyesconfig and allmodconfig on x86 and arm.
> 
> Cc: Eric Dumazet <eric.dumazet at gmail.com>
> Cc: Jay Vosburgh <j.vosburgh at gmail.com>
> Cc: Veaceslav Falico <vfalico at gmail.com>
> Cc: Andy Gospodarek <andy at greyhouse.net>
> Cc: Mirko Lindner <mlindner at marvell.com>
> Cc: Stephen Hemminger <stephen at networkplumber.org>
> Signed-off-by: Tobias Klauser <tklauser at distanz.ch>

Applied, thanks.


More information about the Intel-wired-lan mailing list