[Intel-wired-lan] [PATCH v7 2/2] ixgbe: add support for XDP_TX action

Bowers, AndrewX andrewx.bowers at intel.com
Tue Mar 28 23:11:08 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of John Fastabend
> Sent: Thursday, March 23, 2017 9:32 PM
> To: john.fastabend at gmail.com; alexander.duyck at gmail.com
> Cc: intel-wired-lan at lists.osuosl.org; u9012063 at gmail.com
> Subject: [Intel-wired-lan] [PATCH v7 2/2] ixgbe: add support for XDP_TX
> action
> 
> Add support for XDP_TX action.
> 
> A couple design choices were made here. First I use a new ring pointer
> structure xdp_ring[] in the adapter struct instead of pushing the newly
> allocated xdp TX rings into the tx_ring[] structure. This means we have to
> duplicate loops around rings in places we want to initialize both TX rings and
> XDP rings.
> But by making it explicit it is obvious when we are using XDP rings and when
> we are using TX rings. Further we don't have to do ring arithmatic which is
> error prone. As a proof point for doing this my first patches used only a single
> ring structure and introduced bugs in FCoE code and macvlan code paths.
> 
> Second I am aware this is not the most optimized version of this code
> possible. I want to get baseline support in using the most readable format
> possible and then once this series is included I will optimize the TX path in
> another series of patches.
> 
> Signed-off-by: John Fastabend <john.r.fastabend at intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h         |   19 +
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |   25 ++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c     |   78 +++++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  279
> +++++++++++++++++++---
>  4 files changed, 350 insertions(+), 51 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list