[Intel-wired-lan] [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER

Ding Tianhong dingtianhong at huawei.com
Sun Apr 2 06:49:47 UTC 2017



On 2017/4/2 2:26, David Miller wrote:
> From: Ding Tianhong <dingtianhong at huawei.com>
> Date: Sat, 1 Apr 2017 15:25:51 +0800
> 
>> Till now only the Intel ixgbe could support enable
>> Relaxed ordering in the drivers for special architecture,
>> but the ARCH_WANT_RELAX_ORDER is looks like a general name
>> for all arch, so rename to a specific name for intel
>> card looks more appropriate.
>>
>> Signed-off-by: Ding Tianhong <dingtianhong at huawei.com>
> 
> This is not a driver specific facility.
> 
> Any driver can test this symbol and act accordingly.
> 
> Just because IXGBE is the first and only user, doesn't mean
> the facility is driver specific.
> 

Understand clearly,but the ARCH_WANT_RELAX_ORDER is really too generic and simple,
cause much misleading to indicate that it looks like the hack code for some architecture.
what do you think of the ETHERNET_ALLOW_RELAXED_ORDER in the drivers/net/ethernet/*,
it will only affect ethernet and not only for Ixgbe.

Thanks
Ding


> Thank you.
> 
> .
> 



More information about the Intel-wired-lan mailing list