[Intel-wired-lan] [next PATCH S71 04/10] i40e: remove unnecessary msleep() delay in i40e_free_vfs

Bowers, AndrewX andrewx.bowers at intel.com
Fri Apr 21 18:08:09 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alice Michael
> Sent: Wednesday, April 19, 2017 6:26 AM
> To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S71 04/10] i40e: remove unnecessary
> msleep() delay in i40e_free_vfs
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> The delay was added because of a desire to ensure that the VF driver can
> finish up removing. However, pci_disable_sriov already has its own
> ssleep() call that will sleep for an entire second, so there is no reason to add
> extra delay on top of this by using msleep here. In practice, an msleep()
> won't have a huge impact on timing but there is no real value in keeping it, so
> lets just simplify the code and remove it.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c        | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 --
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c    | 2 +-
>  3 files changed, 2 insertions(+), 4 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list