[Intel-wired-lan] [next PATCH S71 05/10] i40e: separate PF and VSI state flags

Keller, Jacob E jacob.e.keller at intel.com
Fri Apr 21 20:15:06 UTC 2017



> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bowers, AndrewX
> Sent: Thursday, April 20, 2017 4:01 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: Re: [Intel-wired-lan] [next PATCH S71 05/10] i40e: separate PF and VSI
> state flags
> 
> > -----Original Message-----
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> > Behalf Of Alice Michael
> > Sent: Wednesday, April 19, 2017 6:26 AM
> > To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> > lan at lists.osuosl.org
> > Subject: [Intel-wired-lan] [next PATCH S71 05/10] i40e: separate PF and VSI
> > state flags
> >
> > From: Jacob Keller <jacob.e.keller at intel.com>
> >
> > Avoid using the same named flags for both vsi->state and pf->state. This
> > makes code review easier, as it is more likely that future authors will use the
> > correct state field when checking bits. Previous commits already found issues
> > with at least one check, and possibly others may be incorrect.
> >
> > This reduces confusion as it is more clear what each flag represents, and
> > which flags are valid for which state field.
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e.h          |  12 ++-
> >  drivers/net/ethernet/intel/i40e/i40e_client.c   |   4 +-
> >  drivers/net/ethernet/intel/i40e/i40e_debugfs.c  |   4 +-
> >  drivers/net/ethernet/intel/i40e/i40e_main.c     | 104 ++++++++++++---------
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e_txrx.c     |   8 +-
> >  drivers/net/ethernet/intel/i40evf/i40e_txrx.c   |   8 +-
> >  drivers/net/ethernet/intel/i40evf/i40evf.h      |   7 +-
> >  drivers/net/ethernet/intel/i40evf/i40evf_main.c |  10 +--
> >  8 files changed, 83 insertions(+), 74 deletions(-)
> 
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> 
> 

This patch is incorrect. I will send a v2, and I will try to make it fit within the same place in the current dev-queue as it does now.

Thanks,
Jake



More information about the Intel-wired-lan mailing list