[Intel-wired-lan] [PATCH] i40e: separate PF and VSI state flags
Bowers, AndrewX
andrewx.bowers at intel.com
Fri Apr 21 21:29:36 UTC 2017
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Friday, April 21, 2017 1:38 PM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH] i40e: separate PF and VSI state flags
>
> Avoid using the same named flags for both vsi->state and pf->state. This
> makes code review easier, as it is more likely that future authors will use the
> correct state field when checking bits. Previous commits already found issues
> with at least one check, and possibly others may be incorrect.
>
> This reduces confusion as it is more clear what each flag represents, and
> which flags are valid for which state field.
>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
> This version has the fixup! already squashed in for convenience. Again it
> replaces the patch with the same title on the queue.
>
> drivers/net/ethernet/intel/i40e/i40e.h | 12 ++++-
> drivers/net/ethernet/intel/i40e/i40e_client.c | 4 +-
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +-
> drivers/net/ethernet/intel/i40e/i40e_main.c | 66 ++++++++++++-----------
> --
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 +--
> drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 8 +--
> drivers/net/ethernet/intel/i40evf/i40evf.h | 7 ++-
> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 10 ++--
> 8 files changed, 64 insertions(+), 55 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Confirmed fixes earlier regression
More information about the Intel-wired-lan
mailing list