[Intel-wired-lan] [PATCH] igb: Fix error that repeat to add filter when changing adapter speed

Jesse Brandeburg jesse.brandeburg at intel.com
Wed May 3 15:43:48 UTC 2017


On Wed, 3 May 2017 09:20:09 +0800
Gangfeng <gangfeng.huang at ni.com> wrote:

> From: Gangfeng Huang <gangfeng.huang at ni.com>
> 
> Function igb_nfc_filter_exit()/igb_nfc_filter_restore() should be paried,
> igb_nfc_filter_restore exist in igb_up(), but igb_nfc_filter_exit() exist
> in __igb_close(), so move the igb_nfc_filter_exit() to igb_down().

Hi, thanks for your patch.  Are you fixing a bug here? If so, your
commit message should say what you're fixing and how to reproduce it.
Say why you are doing something, not just what you're doing.

In this case, it looks like you probably are fixing a bug, but
definitely need a better commit message.


More information about the Intel-wired-lan mailing list