[Intel-wired-lan] [PATCH v4 05/15] i40e: avoid permanent lock of *_PTP_TX_IN_PROGRESS

Bowers, AndrewX andrewx.bowers at intel.com
Thu May 4 21:58:47 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Wednesday, May 3, 2017 10:29 AM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Cc: Richard Cochran <richardcochran at gmail.com>
> Subject: [Intel-wired-lan] [PATCH v4 05/15] i40e: avoid permanent lock of
> *_PTP_TX_IN_PROGRESS
> 
> The i40e driver uses a bit lock to indicate when a Tx timestamp is in progress
> to avoid attempting to timestamp multiple packets at once. This is required
> because hardware only has registers to handle one request at a time.
> 
> There is a corner case where we failed to cleanup the bit lock after a failed
> transmit. This can potentially result in a state bit being locked forever.
> 
> Add some cleanup code to i40e_xmit_frame_ring to check and make sure we
> cleanup incase of these failures. We also modify i40e_tx_map to return an
> error code indication DMA failure.
> 
> Reported-by: Reported-by: David Mirabito <davidm at metamako.com>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 26 ++++++++++++++++++++--
> ----
>  1 file changed, 20 insertions(+), 6 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list