[Intel-wired-lan] [PATCH v2] e1000e: Don't return uninitialized stats

David Miller davem at davemloft.net
Thu May 18 14:46:14 UTC 2017


From: Benjamin Poirier <bpoirier at suse.com>
Date: Wed, 17 May 2017 16:24:13 -0400

> Some statistics passed to ethtool are garbage because e1000e_get_stats64()
> doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
> memory to userspace and confuses users.
> 
> Do like ixgbe and use dev_get_stats() which first zeroes out
> rtnl_link_stats64.
> 
> Fixes: 5944701df90d ("net: remove useless memset's in drivers get_stats64")
> Reported-by: Stefan Priebe <s.priebe at profihost.ag>
> Signed-off-by: Benjamin Poirier <bpoirier at suse.com>

Jeff, please be sure to pick this up, thanks.


More information about the Intel-wired-lan mailing list