[Intel-wired-lan] [PATCH net] i40e: Fix state flags for bit set and clean operations of PF

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Mauro S. M. Rodrigues
> Sent: Friday, May 12, 2017 7:27 PM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
> Cc: Mauro S. M. Rodrigues <maurosr at linux.vnet.ibm.com>;
> gpiccoli at linux.vnet.ibm.com
> Subject: [Intel-wired-lan] [PATCH net] i40e: Fix state flags for bit set and
> clean operations of PF
> 
> Commit 0da36b9774cc ("i40e: use DECLARE_BITMAP for state fields")
> introduced changes in the way i40e works with state flags converting them to
> bitmaps using kernel bitmap API. This change introduced a regression due to
> a mistaken substitution using __I40E_VSI_DOWN instead of __I40E_DOWN
> when testing state of a PF at i40e_reset_subtask() function. This caused a
> flood in the kernel log with the follow message:
> 
> [49.013] i40e 0002:01:00.0: bad reset request 0x00000020
> 
> Commit d19cb64b9222 ("i40e: separate PF and VSI state flags") also
> introduced some misuse of the VSI and PF flags, so both could be considered
> as the offenders.
> 
> This patch simply fixes the flags where it makes sense by changing
> __I40E_VSI_DOWN to __I40E_DOWN.
> 
> Fixes: 0da36b9774cc ("i40e: use DECLARE_BITMAP for state fields")
> Fixes: d19cb64b9222 ("i40e: separate PF and VSI state flags")
> 
> Reviewed-by: Guilherme G. Piccoli <gpiccoli at linux.vnet.ibm.com>
> Signed-off-by: Mauro S. M. Rodrigues <maurosr at linux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 36 ++++++++++++++----------
> -----
>  1 file changed, 18 insertions(+), 18 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>