[Intel-wired-lan] [PATCH] i40e: Fix a sleep-in-atomic bug

Bowers, AndrewX andrewx.bowers at intel.com
Mon Jun 5 23:28:25 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jia-Ju Bai
> Sent: Tuesday, May 30, 2017 7:12 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
> Cc: netdev at vger.kernel.org; Jia-Ju Bai <baijiaju1990 at 163.com>; intel-wired-
> lan at lists.osuosl.org; linux-kernel at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] i40e: Fix a sleep-in-atomic bug
> 
> The driver may sleep under a spin lock, and the function call path is:
> i40e_ndo_set_vf_port_vlan (acquire the lock by spin_lock_bh)
>   i40e_vsi_remove_pvid
>     i40e_vlan_stripping_disable
>       i40e_aq_update_vsi_params
>         i40e_asq_send_command
>           mutex_lock --> may sleep
> 
> To fixed it, the spin lock is released before "i40e_vsi_remove_pvid", and the
> lock is acquired again after this function.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990 at 163.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |    2 ++
>  1 file changed, 2 insertions(+)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list