[Intel-wired-lan] i40e: fix handling of HW ATR eviction

Bowers, AndrewX andrewx.bowers at intel.com
Mon Jun 12 21:56:55 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Monday, June 12, 2017 2:51 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] i40e: fix handling of HW ATR eviction
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> A recent commit to refactor the driver and remove the hw_disabled_flags
> field accidentally introduced two regressions. First, we overwrote
> pf->flags which removed various key flags including the MSI-X settings.
> 
> Additionally, it was intended that we have now two flags,
> HW_ATR_EVICT_CAPABLe and HW_ATR_EVICT_ENABLED, but this was not
> done, and we accidentally were mis-using HW_ATR_EVICT_CAPABLE
> everywhere.
> 
> This patch adds the missing piece, HW_ATR_EVICT_ENABLED, and safely
> updates pf->flags instead of overwriting it.
> 
> Without this patch we will have many problems including disabling MSI-X
> support, and we'll attempt to use HW ATR eviction on devices which do not
> support it.
> 
> Fixes: 47994c119a36 ("i40e: remove hw_disabled_flags in favor of using
> separate flag bits", 2017-04-19)
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h         |    1 +
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c |    4 ++--
>  drivers/net/ethernet/intel/i40e/i40e_main.c    |    7 ++++---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c    |    4 ++--
>  4 files changed, 9 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list