[Intel-wired-lan] [next PATCH S73-V2 5/9] i40e: fix odd formatting and indent

Bowers, AndrewX andrewx.bowers at intel.com
Thu Jun 22 18:32:54 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Tuesday, June 20, 2017 3:17 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S73-V2 5/9] i40e: fix odd formatting
> and indent
> 
> From: Jesse Brandeburg <jesse.brandeburg at intel.com>
> 
> The compiler warned on an oddly indented bit of code, and when
> investigating that, noted that the functions themselves had an odd flow. The
> if condition was checked, and would exclude a call to AQ, but then the aq_ret
> would be checked unconditionally which just looks really weird, and is likely
> to cause objections.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list