[Intel-wired-lan] [next PATCH S74-V2 05/10] i40e: separate hw_features from runtime changing flags

Shannon Nelson shannon.nelson at oracle.com
Fri Jun 23 17:19:44 UTC 2017


On 6/23/2017 1:24 AM, Alice Michael wrote:
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> The number of flags found in pf->flags has grown quite large, and there
> are a lot of different types of flags. Most of the flags are simply
> hardware features which are enabled on some firmware or some MAC types.
> Other flags are dynamic run-time flags which enable or disable certain
> features of the driver.
> 
> Separate these two types of flags into pf->hw_features and pf->flags.

In general this looks fine and really has long been needed.  My only 
concern is that the name chosen clashes with netdev->hw_features.  This 
is a small nit, but I think a slightly different name would be better in 
the long run.  Even simply "features" would be good.

sln


More information about the Intel-wired-lan mailing list