[Intel-wired-lan] [PATCH 1/2] igbvf: add lock around mailbox ops

Brown, Aaron F aaron.f.brown at intel.com
Fri Jul 28 23:59:26 UTC 2017


> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf
> Of Greg Edwards
> Sent: Thursday, July 20, 2017 9:01 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Greg Edwards <gedwards at ddn.com>
> Subject: [Intel-wired-lan] [PATCH 1/2] igbvf: add lock around mailbox ops
> 
> The PF driver assumes the VF will not send another mailbox message until
> the PF has written its reply to the previous message.  If the VF does,
> that message will be silently dropped by the PF before it writes its
> reply to the mailbox.  This results in a VF mailbox timeout for posted
> messages waiting for an ACK, and the VF is reset by the
> igbvf_watchdog_task in the VM.
> 
> Add a lock around the VF mailbox ops to prevent the VF from sending
> another message while the PF is still processing the previous one.
> 
> Signed-off-by: Greg Edwards <gedwards at ddn.com>
> ---
>  drivers/net/ethernet/intel/igbvf/ethtool.c |  4 +++
>  drivers/net/ethernet/intel/igbvf/mbx.c     |  4 +++
>  drivers/net/ethernet/intel/igbvf/netdev.c  | 47
> ++++++++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igbvf/vf.h      |  1 +
>  4 files changed, 56 insertions(+)

Tested-by: Aaron Brown <aaron.f.brown at intel.com>


More information about the Intel-wired-lan mailing list