[Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

Alexander Duyck alexander.duyck at gmail.com
Mon Aug 28 16:25:46 UTC 2017


On Sun, Aug 27, 2017 at 1:30 AM, Neftin, Sasha <sasha.neftin at intel.com> wrote:
> On 8/25/2017 18:06, Willem de Bruijn wrote:
>>
>> From: Willem de Bruijn <willemb at google.com>
>>
>> Devices that support FLAG2_DMA_BURST have different default values
>> for RDTR and RADV. Apply burst mode default settings only when no
>> explicit value was passed at module load.
>>
>> The RDTR default is zero. If the module is loaded for low latency
>> operation with RxIntDelay=0, do not override this value with a burst
>> default of 32.
>>
>> Move the decision to apply burst values earlier, where explicitly
>> initialized module variables can be distinguished from defaults.
>>
>> Signed-off-by: Willem de Bruijn <willemb at google.com>
>
> This patch looks good for me, but I would like hear second opinion.

This code is an improvement over what was already there. I am good with this.

Acked-by: Alexander Duyck <alexander.h.duyck at intel.com>


More information about the Intel-wired-lan mailing list