[Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and re-number feature flags

Bowers, AndrewX andrewx.bowers at intel.com
Fri Sep 1 21:37:10 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Friday, September 1, 2017 1:54 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and re-
> number feature flags
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Now that we've reduced the number of flags, organize similar flags together
> and re-number them accordingly.
> 
> Since we don't yet have more than 32 flags, we'll use a u32 for both the
> hw_features and flag field. Should we gain more flags in the future, we may
> need to convert to a u64 or separate flags out into two fields.
> 
> One alternative approach considered, but not implemented here, was to use
> an enumeration for the flag variables, and create a macro
> I40E_FLAG() which used string concatenation to generate BIT_ULL values.
> This has the advantage of making the actual bit values compile-time dynamic
> so that we do not need to worry about matching the order to the bit value.
> However, this does produce a high level of code churn, and makes it more
> difficult to read a dumped flags value when debugging.
> 
> v3: rebased patch based on the current dev-queue branch
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Reviewed-by: Mitch Williams <mitch.a.williams at intel.com>
> Change-ID: I8653fff69453cd547d6fe98d29dfa9d8710387d1
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h         | 98 +++++++++++++-------------
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c |  6 +-
>  drivers/net/ethernet/intel/i40evf/i40evf.h     | 32 ++++-----
>  3 files changed, 68 insertions(+), 68 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list