[Intel-wired-lan] [PATCH v3 04/16] fm10k: add missing fall through comment

Singh, Krishneil K krishneil.k.singh at intel.com
Mon Sep 18 17:05:22 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf
> Of Jacob Keller
> Sent: Monday, July 10, 2017 1:23 PM
> To: jtkirhse at osuosl.org; Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Cc: jekeller at osuosl.org
> Subject: [Intel-wired-lan] [PATCH v3 04/16] fm10k: add missing fall through
> comment
> 
> Newer versions of GCC starting with 7 now additionally warn when a case
> statement may fall through without an explicit comment mentioning it.
> Add such a comment to silence the warning, as this is expected.
> 
> Unfortunately the comment must come directly before the next case
> statement, so we put it outside the #ifdef. Otherwise, the compiler
> cannot properly detect it and thus the warning is displayed regardless.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---

Tested-by: Krishneil Singh  <krishneil.k.singh at intel.com> 



More information about the Intel-wired-lan mailing list