[Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix memory leak related filter programming status

Bowers, AndrewX andrewx.bowers at intel.com
Tue Oct 10 16:41:38 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Anders K. Pedersen | Cohaesio
> Sent: Tuesday, October 10, 2017 1:01 AM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
> alexander.duyck at gmail.com
> Subject: Re: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Fix memory
> leak related filter programming status
> 
> On ons, 2017-10-04 at 08:44 -0700, Alexander Duyck wrote:
> > From: Alexander Duyck <alexander.h.duyck at intel.com>
> >
> > It looks like we weren't correctly placing the pages from buffers that
> > had been used to return a filter programming status back on the ring.
> > As a result they were being overwritten and tracking of the pages was
> > lost.
> >
> > This change works to correct that by incorporating part of
> > i40e_put_rx_buffer into the programming status handler code. As a
> > result we should now be correctly placing the pages for those buffers
> > on the re-allocation list instead of letting them stay in place.
> >
> > Fixes: 0e626ff7ccbf ("i40e: Fix support for flow director programming
> > status")
> > Reported-by: Anders K. Pedersen <akp at cohaesio.com>
> > Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> 
> We rebooted the router that had memory leaks on 4.12 and 4.13 kernels with
> 4.13.5 plus this patch this morning, and the memory leak is gone, so
> 
> Tested-by: Anders K. Pedersen <akp at cohaesio.com>

I also tested it and no leaks so

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>



More information about the Intel-wired-lan mailing list