[Intel-wired-lan] [jkirsher/next-queue PATCH] i40e/i40evf: Revert "i40e/i40evf: bump tail only in multiples of 8"

Bowers, AndrewX andrewx.bowers at intel.com
Wed Oct 25 20:39:01 UTC 2017


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Saturday, October 21, 2017 5:52 PM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
> akp at cohaesio.com; pstaszewski at itcare.pl
> Subject: [Intel-wired-lan] [jkirsher/next-queue PATCH] i40e/i40evf: Revert
> "i40e/i40evf: bump tail only in multiples of 8"
> 
> From: Alexander Duyck <alexander.h.duyck at intel.com>
> 
> This reverts commit 11f29003d6376fb123b7c3779dba49bb56fb0815.
> 
> I am reverting this as I am fairly certain this can result in a memory leak when
> combined with the current page recycling scheme. Specifically we end up
> attempting to allocate fewer buffers than we recycled and this results in us
> rewinding the next to alloc pointer which leads to leaks when we overwrite
> the rx_buffer_info when processing the next frame.
> 
> Fixes: 11f29003d637 ("i40e/i40evf: bump tail only in multiples of 8")
> Signed-off-by: Alexander Duyck <alexander.h.duyck at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   |    9 ---------
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c |    9 ---------
>  2 files changed, 18 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list