[Intel-wired-lan] [next PATCH S81-V3 8/9] i40e: Fix for NUP NVM image downgrade failure

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alice Michael
> Sent: Friday, October 27, 2017 8:07 AM
> To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S81-V3 8/9] i40e: Fix for NUP NVM
> image downgrade failure
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Since commit 96a39aed25e6 ("i40e: Acquire NVM lock before reads on all
> devices") we've used the NVM lock to synchronize NVM reads even on
> devices which don't strictly need the lock.
> 
> Doing so can cause a regression on older firmware prior to 1.5, especially
> when downgrading the firmware.
> 
> Fix this by only grabbing the lock if we're running on an X722 device (which
> requires the lock as it uses the AdminQ to read the NVM), or if we're
> currently running 1.5 or newer firmware.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_adminq.c | 6 ++++++
> drivers/net/ethernet/intel/i40e/i40e_common.c | 3 ++-
>  drivers/net/ethernet/intel/i40e/i40e_nvm.c    | 8 +++++---
>  drivers/net/ethernet/intel/i40e/i40e_type.h   | 1 +
>  4 files changed, 14 insertions(+), 4 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>