[Intel-wired-lan] [RFC PATCH jkirsher/next-queue 8/9] ixgbe: add the Rx ipsec offload processing

[Shannon Nelson]

On 11/17/2017 9:45 AM, Alexander Duyck wrote:
> On Thu, Nov 16, 2017 at 11:54 AM, Shannon Nelson
> <shannon.nelson at oracle.com> wrote:
>> Add the ipsec check and processing into the Rx handler.
>>
>> Signed-off-by: Shannon Nelson <shannon.nelson at oracle.com>
>> ---
>>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>> index a434675..2bb4c5f 100644
>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>> @@ -2424,6 +2424,9 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,
>>                          }
>>                  }
>>   #endif /* IXGBE_FCOE */
>> +               /* was IPsec offload processing done?  */
>> +               if (adapter->flags2 & IXGBE_FLAG2_IPSEC_ENABLED)
>> +                       ixgbe_ipsec_process_rx_offload(rx_ring, rx_desc, skb);
>>
>>                  ixgbe_rx_skb(q_vector, skb);
> 
> Generally I prefer to use ring flags rather than global ones. It keeps
> us from having to reach too far. In addition you could probably make
> this a part of ixgbe_process_skb_fields since that is the proper place
> for handling anything that updates metadata in the skb.

Both of those comments make sense.

sln