[Intel-wired-lan] [PATCH] ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

Bowers, AndrewX andrewx.bowers at intel.com
Fri Feb 2 22:32:29 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Monday, January 29, 2018 3:58 PM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: prevent ptp_rx_hang from running
> when in FILTER_ALL mode
> 
> On hardware which supports timestamping all packets, the timestamps are
> recorded in the packet buffer, and the driver no longer uses or reads the
> registers. This makes the logic for checking and clearing Rx timestmap hangs
> meaningless.
> 
> If we run the ixgbe_ptp_rx_hang() function in this case, then the driver will
> continuously spam the log output with "Clearing Rx timestamp hang".
> These messages are spurious, and confusing to end users.
> 
> The original code in commit a9763f3cb54c ("ixgbe: Update PTP to support
> X550EM_x devices", 2015-12-03) did have a flag
> PTP_RX_TIMESTAMP_IN_REGISTER which was intended to be used to avoid
> the Rx timestamp hang check, however it did not actually check the flag
> before calling the function.
> 
> Do so now in order to stop the checks and prevent the spurious log
> messages.
> 
> Fixes: a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices",
> 2015-12-03)
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
> Apparently this fix was not squashed into Mark's upstreaming effort for the
> PTP updates for X550. Here it is now.
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list