[Intel-wired-lan] [next PATCH S86 V3 7/8] i40evf: use __dev_[um]c_sync routines in .set_rx_mode

Bowers, AndrewX andrewx.bowers at intel.com
Tue Feb 6 22:36:51 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Alice Michael
> Sent: Monday, February 5, 2018 3:11 AM
> To: Michael, Alice <alice.michael at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S86 V3 7/8] i40evf: use
> __dev_[um]c_sync routines in .set_rx_mode
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> Similar to changes done to the PF driver in commit 6622f5cdbaf3 ("i40e:
> make use of __dev_uc_sync and __dev_mc_sync"), replace our home-rolled
> method for updating the internal status of MAC filters with __dev_uc_sync
> and __dev_mc_sync.
> 
> These new functions use internal state within the netdev struct in order to
> efficiently break the question of "which filters in this list need to be added or
> removed" into singular "add this filter" and "delete this filter" requests.
> 
> This vastly improves our handling of .set_rx_mode especially with large
> number of MAC filters being added to the device, and even results in a
> simpler .set_rx_mode handler.
> 
> Under some circumstances, such as when attached to a bridge, we may
> receive a request to delete our own permanent address. Prevent deletion of
> this address during i40evf_addr_unsync so that we don't accidentally stop
> receiving traffic.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 109 ++++++++++++++----
> ------
>  1 file changed, 64 insertions(+), 45 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list