[Intel-wired-lan] [PATCH S88 1/8] i40e: Properly check allowed advertisement capabilities

Bowers, AndrewX andrewx.bowers at intel.com
Wed Mar 14 23:09:40 UTC 2018


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Wednesday, March 14, 2018 11:19 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Sokolowski, Jan <jan.sokolowski at intel.com>
> Subject: [Intel-wired-lan] [PATCH S88 1/8] i40e: Properly check allowed
> advertisement capabilities
> 
> From: Jan Sokolowski <jan.sokolowski at intel.com>
> 
> The i40e_set_link_ksettings and i40e_get_link_ksettings use different
> codepaths to check available and supported advertisement modes. This
> creates scenarios where it's possible to set a mode that's not allowed,
> resulting in a link down.
> 
> Fix setting advertisement in i40e_set_link_ksettings by calling
> i40e_get_link_ksettings to check what modes are allowed.
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list